Re: [PATCH v3 4/4] arm64: dts: renesas: r9a09g047e57-smarc: Enable USB2.0 support

[Tommaso Merciai]

Hi Geert,
Thanks for your review.

On Mon, Sep 14, 2026 at 07:42:34PM +0200, Geert Uytterhoeven wrote:
> Hi Tommaso,
> 
> On Wed, 9 Sept 2026 at 10:55, Tommaso Merciai
> <tommaso.merciai.xr@xxxxxxxxxxxxxx> wrote:
> > Enable USB2.0 support on the RZ/G3E EVK board. The USB1B_1A_HOST and
> > USB5_4_HOST connectors support host operation only, while USB0_OTG
> > supports both host and peripheral operation.
> >
> > renesas-smarc2.dtsi is shared by all boards based on the RZ SMARC
> > Carrier II Board. USB2.0 is not yet supported on the RZ/G3L SMARC
> > EVK, so disable the common USB2.0 nodes in its board DTS until proper
> > support is added.
> >
> > Signed-off-by: Tommaso Merciai <tommaso.merciai.xr@xxxxxxxxxxxxxx>
> 
> Thanks for your patch!
> 
> > --- a/arch/arm64/boot/dts/renesas/r9a09g047e57-smarc.dts
> > +++ b/arch/arm64/boot/dts/renesas/r9a09g047e57-smarc.dts
> > @@ -298,6 +298,28 @@ sd1-data {
> >                 };
> >         };
> >
> > +       usb20_pins: usb20 {
> > +               ovc {
> > +                       pinmux = <RZG3E_PORT_PINMUX(0, 0, 12)>; /* USB20_OVRCURN */
> > +                       bias-pull-up;
> > +               };
> > +
> > +               vbus {
> > +                       pinmux = <RZG3E_PORT_PINMUX(0, 1, 12)>; /* USB20_VBUSEN */
> > +               };
> > +       };
> > +
> > +       usb21_pins: usb21 {
> > +               ovc {
> > +                       pinmux = <RZG3E_PORT_PINMUX(G, 6, 12)>; /* USB21_OVRCURN */
> > +                       bias-pull-up;
> > +               };
> > +
> > +               vbus {
> > +                       pinmux = <RZG3E_PORT_PINMUX(K, 3, 12)>; /* USB21_VBUSEN */
> > +               };
> 
> While these two signals are wired to the SLG46108, which generates
> USB1_EN_OC# from that, the latter does not seem to be wired on the
> carrier board (SMARC_MODULE_CN P67)?

You are correct, USB1_EN_OC# -> P67 is not wired on the carrier board.
I will drop usb21_pins in v4.

Kind regards,
Tommaso


> 
> > +       };
> > +
> >         usb3_pins: usb3 {
> >                 pinmux = <RZG3E_PORT_PINMUX(4, 1, 12)>, /* USB30_VBUSEN */
> >                          <RZG3E_PORT_PINMUX(4, 0, 12)>; /* USB30_OVRCURN */
> 
> The rest LGTM.
> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> -- 
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds