Re: [PATCH] net: dsa: vitesse-vsc73xx: Fix SPI device reference leak in vsc73xx_spi_probe()

[Simon Horman]

On Fri, Sep 18, 2026 at 12:22:12AM +0200, Linus Walleij wrote:
> On Thu, Sep 17, 2026 at 12:49 PM Wentao Liang <vulab@xxxxxxxxxxx> wrote:
> 
> > spi_dev_get() takes a reference on the SPI device, but neither the
> > probe error paths nor vsc73xx_spi_remove() ever release it, so the
> > spi_device can never be freed after the driver has been unbound.
> >
> > Release the reference on both probe error paths and in remove().
> >
> > Fixes: 95711cd5f0b4 ("net: dsa: vsc73xx: Split vsc73xx driver")
> > Cc: stable@xxxxxxxxxxxxxxx
> 
> I think we don't set this on networking patches, the network maintainer
> decides himself what is stable material.

Hi Linus,

That was the case in the past.
But these days following the standard stable procedure is encouraged.

Link: https://docs.kernel.org/process/maintainer-netdev.html#stable-tree

> 
> > Signed-off-by: Wentao Liang <vulab@xxxxxxxxxxx>
> 
> Reviewed-by: Linus Walleij <linusw@xxxxxxxxxx>
> 
> Yours,
> Linus Walleij