Re: [PATCH] siox: fix master memory leak on registration failure

[Markus Elfring]

…
> +++ b/drivers/siox/siox-core.c
> @@ -753,14 +753,21 @@ int siox_master_register(struct siox_master *smaster)
>  	smaster->poll_thread = kthread_run(siox_poll_thread, smaster,
>  					   "siox-%d", smaster->busno);
>  	if (IS_ERR(smaster->poll_thread)) {
> +		ret = PTR_ERR(smaster->poll_thread);

Would it be nicer to use this variable assignment directly before
the goto statement?


>  		smaster->active = 0;
> -		return PTR_ERR(smaster->poll_thread);
> +		goto err_put_device;
>  	}
…


Regards,
Markus