Re: [PATCH v2 00/18] Add DT support for CSI2RX multi-stream

[Rishikesh Donadkar]

On 26/08/26 12:20, Krzysztof Kozlowski wrote:
> On 26/08/2026 07:46, Rishikesh Donadkar wrote:
> > On 13/07/26 17:04, Yemike Abhilash Chandra wrote:
> > > Support for multi-stream in j721e-csi2rx.c driver was merged last cycle[0].
> > > This series adds the corresponding device tree support.
> > >
> > > Patch 1 is a cleanup fixing indentation in the existing CSI2RX nodes.
> > >
> > > The next few patches i.e. (Patch 2 to Patch 6) add the additional DMA
> > > channels required for CSI2RX multi-stream capture.
> > >
> > > Multi-stream capture uses a SERDES pair based on the FPD-Link or
> > > V3Link protocol. The serializer takes the input from a camera sensor
> > > and converts it to the FPD-Link standard, while the deserializer
> > > aggregates streams from multiple serializers and sends them over the
> > > CSI-2 RX interface. Each CSI2RX instance therefore indirectly receives
> > > input from multiple sensors.
> > >
> > > The remaining patches add overlays for various deserializer boards,
> > > and for the UB953 serializer with the IMX219 sensor. Also enabling
> > > DS90UB960 deserializer and DS90UB953 serializer drivers in the
> > > arm64 defconfig.
> >
> > Hi Abhilash,
> >
> > Thank you for the series. LGTM !
> >
> > For the entire series,
> >
> > Reviewed-by: Rishikesh Donadkar <r-donadkar@xxxxxx>
>
> You did not have comments for v1, no comments here, so are you really
> reviewed it (considering code has obvious issues)?

Hi Krzysztof,

[PATCH 01/18 - 06/18] enables more DMA channels to support multi-camera 
use cases. I checked the DMA thread ID ranges in the TISCI docs [1] 
(search for "csi" in "<platform> PSI-L Device Descriptions" links). I 
don't see any problem in these patches.

The daughter card overlays added in [PATCH 07/18 - 17/18] have undergone 
multiple rounds of offline testing in TI downstream tree as well as 
upstream. As shown in the test logs attached by Abhilash, everything is 
functioning correctly.

Thank you for pointing out the code improvements that I missed, will 
take a closer look next time :)


[1]: https://software-dl.ti.com/tisci/esd/latest/5_soc_doc/index.html

Thanks & Regards,
Rishikesh


> Best regards,
> Krzysztof