Re: [PATCH] scsi: zorro7xx: put SCSI host on remove
From: krzk
Date: Mon Sep 21 2026 - 11:29:05 EST
On Sat, 19 Sep 2026 02:02:01 +0800, Guangshuo Li wrote:
> zorro7xx_init_one() obtains a SCSI host through NCR_700_detect(). The
> probe failure path drops the host reference with scsi_host_put(), but
> the normal remove path does not perform the corresponding cleanup.
>
> As a result, the SCSI host reference remains allocated after the
> device is removed.
>
> Call scsi_host_put() after all users of the SCSI host have been torn
> down to release the reference acquired during probe.
>
> This issue was found by manual code inspection.
>
> Fixes: 45804fbb00ee ("[SCSI] 53c700: Amiga Zorro NCR53c710 SCSI")
> Cc: stable@xxxxxxxxxxxxxxx
> Signed-off-by: Guangshuo Li <lgs201920130244@xxxxxxxxx>
> ---
> drivers/scsi/zorro7xx.c | 1 +
> 1 file changed, 1 insertion(+)
>
You sent multiple independent patches, to multiple independent
subsystems. The amount of these patches clearly suggest this was
AI generated and most likely not tested.
More importantly, you sent all this work without properly organizing
relevant patches into patchsets. This makes reviewing difficult
and might cause multiple reviewers to address the same issue.
Replying to the entire set is impossible and requires handling each
patch independently, instead of applying or discarding the set.
Maintainers also won't see the bigger picture of your work. Quite
worrying.
This is on the verge of hostile patch: bomb us with so many
contributions, we won't be able to handle them in efficient manner,
like responding ONCE to ask you to slow down. Considering all this
is untested and LLM generated, I have even more doubts whether this
should be considered for review.
Please read kernel documentation BEFORE posting more work. It will
explain you how to identify subsystems, how to organize your work per
subsystem, how to document usage of LLM and how what you should not
do if this was posted in a good faith.
Best regards,
Krzysztof