Re: [PATCH] EDAC/i10nm: Fix mdev reference leak in i10nm_get_ddr_munits()

From: Luck, Tony

Date: Mon Sep 21 2026 - 12:14:29 EST


On Fri, Sep 18, 2026 at 10:34:37PM -0700, Borislav Petkov wrote:
> Hi Tony,
>
> On Thu, Sep 17, 2026 at 04:35:44PM -0700, Luck, Tony wrote:
> > On Wed, Sep 16, 2026 at 09:12:51AM +0000, Wentao Liang wrote:
> > > In i10nm_get_ddr_munits(), get_ddr_munit() returns a PCI device with
> > > its reference count incremented. If ioremap() fails to map the MMIO
> > > space of the memory controller, the function returns -ENODEV without
> > > putting the reference held by mdev, leaking it.
> > >
> > > Put the device reference before returning on the ioremap failure path.
> >
> > Applied. Thanks.
>
> this one has CC:stable. That means it needs to go to Linus now. If so, it
> needs to be into edac-urgent.

I though urgent was for:
1) Fixing something that broke in the current merge window
2) Fixing something that's really important (security, corruption)

This is just an old issue that's been around for ages.
>
> Yes? No?

No.

-Tony