Re: [PATCH 2/3] pmdomain: imx8m-blk-ctrl: Use pm_runtime_resume_and_get()

[Frank Li]

On Mon, Sep 21, 2026 at 10:37:07AM +0700, phucduc.bui@xxxxxxxxx wrote:
> From: bui duc phuc <phucduc.bui@xxxxxxxxx>
>
> Replace the open-coded pm_runtime_get_sync() + pm_runtime_put_noidle()
> error handling pattern with pm_runtime_resume_and_get(), which already
> does this internally.
>
> No functional change.
>
> Found by manual code inspection.
>
> Signed-off-by: bui duc phuc <phucduc.bui@xxxxxxxxx>
> ---

Reviewed-by: Frank Li <Frank.Li@xxxxxxx>

>  drivers/pmdomain/imx/imx8m-blk-ctrl.c | 15 +++++----------
>  1 file changed, 5 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/pmdomain/imx/imx8m-blk-ctrl.c b/drivers/pmdomain/imx/imx8m-blk-ctrl.c
> index 479789009c7f..fe083b1e7251 100644
> --- a/drivers/pmdomain/imx/imx8m-blk-ctrl.c
> +++ b/drivers/pmdomain/imx/imx8m-blk-ctrl.c
> @@ -99,9 +99,8 @@ static int imx8m_blk_ctrl_power_on(struct generic_pm_domain *genpd)
>  	int ret;
>
>  	/* make sure bus domain is awake */
> -	ret = pm_runtime_get_sync(bc->bus_power_dev);
> +	ret = pm_runtime_resume_and_get(bc->bus_power_dev);
>  	if (ret < 0) {
> -		pm_runtime_put_noidle(bc->bus_power_dev);
>  		dev_err(bc->dev, "failed to power up bus domain\n");
>  		return ret;
>  	}
> @@ -382,20 +381,16 @@ static int imx8m_blk_ctrl_suspend(struct device *dev)
>  	 * in the system suspend/resume paths due to the device parent/child
>  	 * hierarchy.
>  	 */
> -	ret = pm_runtime_get_sync(bc->bus_power_dev);
> -	if (ret < 0) {
> -		pm_runtime_put_noidle(bc->bus_power_dev);
> +	ret = pm_runtime_resume_and_get(bc->bus_power_dev);
> +	if (ret < 0)
>  		return ret;
> -	}
>
>  	for (i = 0; i < bc->onecell_data.num_domains; i++) {
>  		struct imx8m_blk_ctrl_domain *domain = &bc->domains[i];
>
> -		ret = pm_runtime_get_sync(domain->power_dev);
> -		if (ret < 0) {
> -			pm_runtime_put_noidle(domain->power_dev);
> +		ret = pm_runtime_resume_and_get(domain->power_dev);
> +		if (ret < 0)
>  			goto out_fail;
> -		}
>  	}
>
>  	return 0;
> --
> 2.43.0
>
>