Re: [PATCH] net: ena: fix PHC cleanup on probe failure

[Guangshuo Li]

Hi Arthur,

Thanks for the review.

On Wed, 16 Sept 2026 at 13:44, Arthur Kiyanovski <akiyano@xxxxxxxxxx> wrote:
>
> On Wed, 16 Sep 2026 10:29:54 +0800, Guangshuo Li <lgs201920130244@xxxxxxxxx> wrote:
> > diff --git a/drivers/net/ethernet/amazon/ena/ena_netdev.c b/drivers/net/ethernet/amazon/ena/ena_netdev.c
> > index ea89619039d8..5f0864d16dd3 100644
> > --- a/drivers/net/ethernet/amazon/ena/ena_netdev.c
> > +++ b/drivers/net/ethernet/amazon/ena/ena_netdev.c
> > @@ -4122,6 +4122,7 @@ static int ena_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
> >  err_device_destroy:
> >       ena_com_delete_host_info(ena_dev);
> >       ena_com_admin_destroy(ena_dev);
> > +     ena_phc_destroy(adapter);
> >  ena_devlink_destroy:
> >       ena_devlink_free(devlink);
> >  err_metrics_destroy:
>
> Thank you for the patch.
> It looks correct.
>
> Please resend this together with "net: ena: fix MMIO read buffer leak on
> probe failure" as one two-patch series - both insert a line into the same
> hunk, so they conflict with each other.
>
> --
> Arthur Kiyanovski <akiyano@xxxxxxxxxx>

Sure, I'll resend both fixes as a two-patch series, with the PHC cleanup
as 1/2 and the MMIO read buffer cleanup as 2/2.

Thanks,
Guangshuo