Re: [PATCH net RESEND 1/2] net: macb: Preserve one-step mode on rejected timestamp requests

[Théo Lebrun]

Hello 김우석,

On Mon Sep 21, 2026 at 5:48 PM CEST, 김우석 wrote:
> Thanks for explaining the approach.

No worries, doing it especially as you are new according to the lore
mailing list history. Welcome!

> I found both issues while validating hardware timestamp configuration
> on the Raspberry Pi 5's Ethernet interface for my research. I reproduced
> them on the board and tested both fixes there, as described in the
> cover letter. These were hardware-verified failures, rather than
> cleanup based only on source inspection.

Great news. Nowadays the difference between "LLM found an issue through
static analysis, generated bugfix and sent it" versus "someone had a
real issue and fixed it with the LLM help" is hard to tell, and the
first approach is sadly more common.

> I've already applied the fixes locally on my Pi, so there is no
> immediate urgency on my side. That said, the structure you suggested
> looks like a cleaner way to handle the configuration path overall, and
> I think it makes sense to take this opportunity to rework it in that
> direction rather than keep the changes limited to the current fixes.
>
> Rather than posting a v2 limited to the current two fixes, I'll prepare
> a new series that refactors gem_set_hwtst() along those lines and
> incorporates both fixes. I'll link back to this series for context and
> validate the reworked path on the Pi 5.

Perfect. Make sure to fix your SoB: we require real names in the kernel
and kimwooseok looks more like a username.

Side tangent: I wouldn't be surprised if you were even allowed to use
Hanguls if you preferred. Though there isn't a large precedent, I hope
we can assume (1) systems have full unicode range support and (2) no
one expects a name to always be firstname + lastname.

⟩ git log torvalds/master | grep -a -P 'Signed-of.*\p{Hangul}'
    Signed-off-by: 이상호 <...@gmail.com>
    Signed-off-by: 배석진 <...@samsung.com>

My own "é" never caused much trouble.

Thanks,

--
Théo Lebrun, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com