Re: [PATCH] KVM: selftests: Fix arm64 sysreg header dependencies
From: Oliver Upton
Date: Mon Sep 21 2026 - 16:39:07 EST
Hey Fuad,
Thanks for the fix here.
On Wed, Sep 02, 2026 at 02:41:18PM +0100, Fuad Tabba wrote:
> ---
> Unlike the two existing sysreg-defs.h rules, this one's recipe is a recursive
> make, so its prerequisites are not the recipe's arguments. They only decide
> whether to recurse, which is a question tools/arch/arm64/tools/Makefile already
> answers. An alternative is therefore to drop the two explicit inputs in favour
> of:
>
> $(GEN_SYSREG_DEFS): FORCE
>
> leaving that Makefile as the only place naming the generator's inputs. Both
> forms regenerate the header and rebuild the dependents in the same invocation,
> and neither rebuilds anything when nothing changed. I kept the explicit
> prerequisites so that the recursion stays conditional, but I am happy to respin
> with FORCE if you would rather.
This might be the better approach at this point. In the unlikely event
that new dependencies get added to the kernel side of this, I'll give it
approximately a 0% chance that the author will update this rule :)
Thanks,
Oliver