Re: [PATCH 06/11] PM: runtime: Expand introduction with core concepts and structure

[Rafael J. Wysocki (Intel)]

On Mon, Sep 21, 2026 at 9:57 PM Brian Norris <briannorris@xxxxxxxxxxxx> wrote:
>
> Hi Rafael,
>
> Thanks for the review!
>
> On Thu, Sep 17, 2026 at 09:59:36PM +0200, Rafael J. Wysocki (Intel) wrote:
> > On Fri, Sep 4, 2026 at 11:20 PM Brian Norris <briannorris@xxxxxxxxxxxx> wrote:
> > >
> > > I commonly see people have difficulty learning how runtime PM works
> > > because of the following key points [*]:
> > >
> > >  1) there are several boolean concepts in runtime PM, with somewhat
> > >     similar meanings:
> > >
> > >      enabled / disabled
> > >      active / suspended
> > >      allowed / forbidden
> > >
> > >  2) if these concepts are documented at all, they're scattered across
> > >     the kerneldoc or Documentation/
> > >
> > >  3) the runtime_pm.rst docs don't make any attempt to ease a reader into
> > >     understanding the concepts, and instead jump straight into how it's
> > >     implemented (queues, 'struct device' fields, helpers).
> > >
> > > Let's try to remedy this a bit by discussing the core concepts and
> > > highlights at the top of the introduction, and introduce a few
> > > sub-headings, so it's easier to navigate different aspects of the
> > > introduction.
> > >
> > > While shuffling the intro around, I also see that the existing text
> > > largely mirrors the layout of the following sections (2, 3, and 4), but
> > > does so out of order. Reorder those, and point to section numbers.
> > >
> > > [*] In addition to API complexity. I count 61 pm_*() helpers, 7 of which
> > >     are variations of put() and 8 of which are variations of get().
> > >
> > > Signed-off-by: Brian Norris <briannorris@xxxxxxxxxxxx>
> > > ---
> > >
> > >  Documentation/power/runtime_pm.rst | 87 +++++++++++++++++++++++-------
> > >  1 file changed, 68 insertions(+), 19 deletions(-)
> > >
> > > diff --git a/Documentation/power/runtime_pm.rst b/Documentation/power/runtime_pm.rst
> > > index 39fdeeda7a1e..620b6988deca 100644
> > > --- a/Documentation/power/runtime_pm.rst
> > > +++ b/Documentation/power/runtime_pm.rst
> > > @@ -11,31 +11,80 @@ Runtime Power Management Framework for I/O Devices
> > >  1. Introduction
> > >  ===============
> > >
> > > -Support for runtime power management (runtime PM) of I/O devices is provided
> > > -at the power management core (PM core) level by means of:
> > > -
> > > -* The power management workqueue pm_wq in which bus types and device drivers can
> > > -  put their PM-related work items.  It is strongly recommended that pm_wq be
> > > -  used for queuing all work items related to runtime PM, because this allows
> > > -  them to be synchronized with system-wide power transitions (suspend to RAM,
> > > -  hibernation and resume from system sleep states).  pm_wq is declared in
> > > -  include/linux/pm_runtime.h and defined in kernel/power/main.c.
> > > -
> > > -* A number of runtime PM fields in the 'power' member of 'struct device' (which
> > > -  is of the type 'struct dev_pm_info', defined in include/linux/pm.h) that can
> > > -  be used for synchronizing runtime PM operations with one another.
> > > +Runtime power management (or runtime PM, sometimes shortened to RPM) allows
> > > +individual I/O devices to transition between high and low-power states
> > > +dynamically while the system is running, conserving power without waiting for a
> > > +system-wide sleep state.
> > > +
> > > +Core Concepts
> > > +-------------
> > > +
> > > +Understanding runtime PM requires distinguishing between several pairs of
> > > +complementary states that operate orthogonally: **active** / **suspended**,
> > > +**enabled** / **disabled**, and **allowed** / **forbidden**.
> > > +
> > > +* **Active**: The PM core tracks a device's runtime status as either **active**
> > > +  (the device is operational, having completed its resume callback) or
> > > +  **suspended** (the device is idle or in a low-power state, having
> > > +  completed its suspend callback), along with transitional **suspending**
> > > +  and **resuming** phases. State transitions are primarily driven by
> > > +  reference counting: drivers call pm_runtime_get() (or related variants)
> > > +  when the hardware is needed (ensuring the device is active) and
> > > +  pm_runtime_put() when work completes, allowing the PM core to initiate
> > > +  suspension (immediately or after an autosuspend delay) once the usage
> > > +  counter and any active child dependencies reach zero.
> >
> > While the above is fine IMV, the enabled/disabled concept is more
> > fundamental
>
> Sure. So perhaps "enabled" should come first in the introduction? And
> then the (non-orthogonal, per below) relationships can be described when
> introducing the others?

Yes, something like that.

> > because "active" and "suspended" are not really relevant
> > when runtime PM is disabled.  Yes, they need to be set properly before
> > enabling it and there is some complexity related to the integration
> > with system-wide PM, but generally speaking, if runtime PM is disabled
> > for a given device, its active/suspended status is irrelevant.
>
> I think you've hit on a key point here, which makes it hard to
> understand RPM sometimes. Indeed enabled-vs-active are not fully
> orthogonal, but then, I also think your "generally speaking" qualifier
> is holding a lot of weight here -- there are quite a few ways in which
> active/suspended are relevant independently of enabled/disabled.
>
> For one, an active disabled device *will* prevent its parent from
> suspending, while a suspended disabled device will not. (Now, is that an
> *important* state? An expected state? Maybe not really, but it at least
> clouds a reader's mental model.)

So there are two things, the status and the reference counters.

The runtime suspend of a parent/supplier is prevented by the latter,
not by the former, so if you never enable runtime PM for a device or
otherwise cause the runtime PM reference counters of the parent and
suppliers to get updated, it will never affect the parent or
suppliers.

However, if you enable runtime PM for a device, you runtime-resume it
and then you disable runtime PM, the reference counters will remain
unchanged.

> And then, reading these 3 helpers, I constantly have to refer back to
> their implementation:
>
>         pm_runtime_active()
>         pm_runtime_suspended()
>         pm_runtime_status_suspended()
>
> The existence of pm_runtime_status_suspended() (which ignores
> disable_depth) means I can never fully apply the reasoning you suggest.
> I need to consider both the disable_depth and the runtime_status when
> understanding how a device will behave.

Well, as I said above, runtime_status doesn't really matter if
disable_depth is nonzero.  Reference counters are a different matter,
which I guess is the source of confusion here.

But basically, nonzero disable_depth really only means that the
device's runtime PM callbacks cannot run and its status will not
change unless explicitly updated with
pm_runtime_set_active/suspended().

> > > +
> > > +* **Enabled**: Orthogonal to whether a device is currently active or suspended
> > > +  is whether runtime PM is **enabled** or **disabled**.
> >
> > So it is not orthogonal.
>
> Perhaps "independent" is a better term? I agree they're not fully
> unrelated, but they're also not fully dependent -- active/suspended has
> significant meaning even when disabled.
>
> In any case, I'll try to incorporate some more color about how they do
> relate.

IMV, "enabled" and "disabled" are not really states, they just tell
you what can happen to the device and what can be done to it.

"Active" and "suspended" are (meta)states that tell you what has
happened to the device most recently.

They aren't completely orthogonal (or independent) because "disabled"
means that whatever has happened to the device recently is now sticky
until something is explicitly done to it.

> > > This is governed by an
> > > +  internal disable counter (``disable_depth``). All devices are initialized
> > > +  with runtime PM disabled (``disable_depth == 1``)
> >
> > This is only partially true because the PCI bus type, for instance,
> > enables runtime PM for all PCI devices and so it is enabled when
> > drivers get to them.
>
> Ack. I had this in mind at some point during the drafting, but when RPM
> is so complicated, it's hard to choose where and when to document all
> the exceptions.
>
> > > and can also be disabled
> > > +  during system sleep transitions or explicitly via pm_runtime_disable(). In
> > > +  the disabled state, the PM core ignores idle and suspend requests and will
> > > +  not execute runtime PM callbacks (->runtime_suspend(), ->runtime_resume(),
> > > +  ->runtime_idle()).
> >
> > Moreover, parent-child and supplied-consumer dependencies are
> > generally not tracked for devices with disabled runtime PM.
>
> Is that really true? A disabled-but-active device still prevents its
> parents and suppliers from suspending, as far as I can tell.

Well, OK, but I've already covered this above.

> If I can interpret *your* intended mental model: if we intend not to
> RPM-manage a device, it should be left disabled and suspended, in which
> case it will generally be ignored by RPM. (Or alternatively:
> disabled-but-active is not generally an expected long-term "steady"
> state.)

Right.  More precisely, its references to the parent and suppliers
need to be dropped.

> But if that's all true, I'm still not sure what to document, to balance
> focus and simplicity (for an introduction) vs covering all the edge
> cases and complexities. Perhaps for an intro: we start with
> "enabled/disabled", and suggest that if a driver never touches RPM (and
> never "enables" the device), RPM mostly stays out of the way.

I would do that.

> But if we want to opt into RPM, then we enable() (and then start to
> think about active/suspended, per the 2nd key state).

Well, actually enable() may need to be preceded with taking references
to the parent and suppliers.

> [ Side note: since you mentioned PCI... that gets into a real-world case
>   of confusion: I've dealt with PCI driver authors that want to "prevent
>   runtime PM" in their driver [*], since they hadn't finished validating
>   all the runtime_suspend/resume behavior for a particular device. In
>   that case, pm_runtime_disable() was actually an OK choice, because the
>   PCI device was already active. But if they applied your quoted
>   reasoning, they'd have to choose something else. (And frankly, they
>   probably should.) But would that be forbid()? Or get()? That's exactly
>   the sort of question I'd hope this document can help clarify.
>
>   [*] ...yes, the PCI bus purposely holds a usage count, requiring
>   drivers to opt into RPM by pm_runtime_put_noidle() or similar... But
>   the question arises nonetheless, when people aren't really RPM
>   experts, and they're dealing with vendor drivers with odd code
>   structure. ]

I can totally agree that this whole thing is not easy to use.  I'm not
sure though if it might be made (much) easier to use TBH.