Re: [PATCH v7 3/3] kselftest: mm: remove check_huge_shmem()
From: Zi Yan
Date: Mon Sep 21 2026 - 21:35:22 EST
On Mon Sep 21, 2026 at 6:40 AM EDT, Yeoreum Yun wrote:
> check_huge_shmem() was required to distinguish shmem huge pages because
> /proc/self/smaps reports them using a dedicated “ShmemPmdMapped” entry,
> as opposed to “FilePmdMapped” for file-backed huge pages.
>
> Now that /proc/self/smaps is no longer used to detect huge pages and
> /proc/kpageflags is used instead, it is sufficient to distinguish
> between file-backed and anonymous pages since the ShmemPmdMapped is also
> kind of file-backed.
>
> Therefore, remove check_huge_shmem() and use check_huge_file() instead
> and cleanup khugepaged's check_huge operation in mem_ops.
>
> Suggested-by: David Hildenbrand (Arm) <david@xxxxxxxxxx>
> Signed-off-by: Yeoreum Yun <yeoreum.yun@xxxxxxx>
> ---
> tools/testing/selftests/mm/folio_split_race_test.c | 2 +-
> tools/testing/selftests/mm/khugepaged.c | 38 ++++------------------
> tools/testing/selftests/mm/uffd-common.c | 4 +--
> tools/testing/selftests/mm/vm_util.c | 5 ---
> tools/testing/selftests/mm/vm_util.h | 1 -
> 5 files changed, 9 insertions(+), 41 deletions(-)
>
Makes sense.
Acked-by: Zi Yan <ziy@xxxxxxxxxx>
--
Best Regards,
Yan, Zi