Re: [PATCH v2 08/10] ntfs: persist immutable in the $LXFLAGS EA

[Hyunchul Lee]

2026년 9월 22일 (화) 오후 12:27, liubaolin <liubaolin12138@xxxxxxx>님이 작성:
>
>
>
> 在 2026/9/22 09:21, Hyunchul Lee 写道:
> > Hi Baolin,
> >
> > 2026년 9월 20일 (일) 오후 5:32, Baolin Liu <liubaolin12138@xxxxxxx>님이 작성:
> >>
> >> From: Baolin Liu <liubaolin@xxxxxxxxxx>
> >>
> >> Add a fileattr setter for immutable and store its state in bit 0 of a
> >> little-endian u32 in the private $LXFLAGS EA. Reuse the standard NTFS EA
> >> attributes and restore the flag when loading an inode, so eviction and
> >> unmount do not discard the setting.
> >
> >
> > I think that the name $LXFLAGS is not appropriate. the prefix $LX
> > seems to be a WSL-owned namespace. The name could cause
> > confusion or a future semantics collision with Windows WSL.
> >
> > Thanks,
> > Hyunchul
>
> Hi Hyunchul,
>
>    Thanks for pointing this out. I agree that we should avoid the $LX
> prefix to prevent confusion or a future semantics collision with WSL.
>
>    Would $LINUXFLAGS be an acceptable name for this private EA?
>
>    If you agree, I'll update the code and documentation, rerun the
> relevant tests, including the Windows NTFS and CHKDSK compatibility
> tests with the new name, and submit the revised patches as v4.

I agree. And others look good to me.
Feel free to add my review tag for this patch set.

Reviewed-by: Hyunchul Lee <hyc.lee@xxxxxxxxx>

>
>    I look forward to your feedback.
>
> Thanks,
> Baolin.
>


-- 
Thanks,
Hyunchul