Re: [PATCH net 09/12] net: systemport: Fix inverted error messages in bcm_sysport_stop()

[Nicolai Buchwitz]

On 22.9.2026 01:13, Florian Fainelli wrote:
> In bcm_sysport_stop(), the error messages printed when 
> tdma_enable_set()
> and rdma_enable_set() time out were inverted: the failure of
> tdma_enable_set() logged 'timeout disabling RDMA' and the failure of
> rdma_enable_set() logged 'timeout disabling TDMA'.
>
> Swap the error messages so they correctly describe the failing engine.
>
> Fixes: 80105befdb4b ("net: systemport: add Broadcom SYSTEMPORT Ethernet 
> MAC driver")
> Assisted-by: LLM
> Signed-off-by: Florian Fainelli <florian.fainelli@xxxxxxxxxxxx>
> ---
>  drivers/net/ethernet/broadcom/bcmsysport.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/broadcom/bcmsysport.c 
> b/drivers/net/ethernet/broadcom/bcmsysport.c
> index 130545cce045..384423b312ca 100644
> --- a/drivers/net/ethernet/broadcom/bcmsysport.c
> +++ b/drivers/net/ethernet/broadcom/bcmsysport.c
> @@ -2089,7 +2089,7 @@ static int bcm_sysport_stop(struct net_device 
> *dev)
>
>  	ret = tdma_enable_set(priv, 0);
>  	if (ret) {
> -		netdev_err(dev, "timeout disabling RDMA\n");
> +		netdev_err(dev, "timeout disabling TDMA\n");
>  		return ret;
>  	}
>
> @@ -2098,7 +2098,7 @@ static int bcm_sysport_stop(struct net_device 
> *dev)
>
>  	ret = rdma_enable_set(priv, 0);
>  	if (ret) {
> -		netdev_err(dev, "timeout disabling TDMA\n");
> +		netdev_err(dev, "timeout disabling RDMA\n");
>  		return ret;
>  	}

Reviewed-by: Nicolai Buchwitz <nb@xxxxxxxxxxx>

Thanks,
Nicolai