Re: [PATCH net v6 1/2] net: validate virtio checksum start after network header
From: Michael S. Tsirkin
Date: Tue Sep 22 2026 - 04:56:10 EST
On Tue, Sep 22, 2026 at 07:56:23AM +0200, Johannes Berg wrote:
> On Tue, 2026-09-22 at 01:14 -0400, Michael S. Tsirkin wrote:
> >
> > >
> > > +/*
> > > + * Return the L3 offset and protocol of an Ethernet frame starting at skb->data.
> > > + * The offset is unused without NEEDS_CSUM, so avoid parsing and return zero.
> > > + */
> >
> > for networking code multiline comments:
> >
> > /* always
> > * look like this
> > */
> >
> > /*
> > * never
> > * like this
> > */
>
> This, for the record, is't really true any more - we dropped the special
> rule a few years ago.
>
> johannes
Oh good to know. thanks!