Re: [PATCH net-next v3 5/8] net: dsa: motorcomm: Introduce yt921x_speed

[Andrew Lunn]

> +	if (ps == YT921X_SPEED_NUM)
>  		return -EINVAL;
> -	}

> +enum yt921x_speed {
> +	YT921X_SPEED_10,
> +	YT921X_SPEED_100,
> +	YT921X_SPEED_1000,
> +	YT921X_SPEED_10000,
> +	YT921X_SPEED_2500,
> +	YT921X_SPEED_NUM
> +};

A nitpick, but i think YT921X_SPEED_NUM could be better named, like
YT921X_SPEED_INVALID.

	Andrew