Re: [PATCH 3/4] driver: core: remove dev_set_drv_sync_state()

[Sverdlin, Alexander]

On Fri, 2026-06-26 at 12:32 -0400, Brian Masney wrote:
> dev_set_drv_sync_state() is no longer used since all users have been
> migrated to dev_add_sync_state(), so let's go ahead and remove it.
> 
> Signed-off-by: Brian Masney <bmasney@xxxxxxxxxx>
> Assisted-by: Claude:claude-opus-4-6

Assuming this is v3 (not specified in the Subject),
Reviewed-by: Alexander Sverdlin <alexander.sverdlin@xxxxxxxxxxx>

> ---
>  include/linux/device.h | 12 ------------
>  1 file changed, 12 deletions(-)
> 
> diff --git a/include/linux/device.h b/include/linux/device.h
> index b7a3dd4b56ed..7f71217ecd48 100644
> --- a/include/linux/device.h
> +++ b/include/linux/device.h
> @@ -1128,18 +1128,6 @@ static inline void device_lock_assert(struct device *dev)
>  	lockdep_assert_held(&dev->mutex);
>  }
>  
> -static inline int dev_set_drv_sync_state(struct device *dev,
> -					 void (*fn)(struct device *dev))
> -{
> -	if (!dev || !dev->driver)
> -		return 0;
> -	if (dev->driver->sync_state && dev->driver->sync_state != fn)
> -		return -EBUSY;
> -	if (!dev->driver->sync_state)
> -		dev->driver->sync_state = fn;
> -	return 0;
> -}
> -
>  struct sync_state_entry {
>  	struct list_head	node;
>  	void			(*fn)(struct device *dev);

-- 
Alexander Sverdlin
Siemens AG
www.siemens.com