Re: [PATCH 2/4] pmdomain: core: migrate to dev_add_sync_state()

From: Sverdlin, Alexander

Date: Tue Sep 22 2026 - 08:05:48 EST


On Fri, 2026-06-26 at 12:32 -0400, Brian Masney wrote:
> We have cases where a device node represents a provider for multiple
> types of resources, like clocks, power-domains, resets, etc. Having just
> a single sync_state on the device is not sufficient since other
> frameworks will want to add their own sync_state callback.
>
> Migrate the pmdomain core code from dev_set_drv_sync_state() to
> dev_add_sync_state() so that this works nicely with other frameworks
> that want to add their own sync_state callback.
>
> Signed-off-by: Brian Masney <bmasney@xxxxxxxxxx>
> Assisted-by: Claude:claude-opus-4-6

Assuming this is v3 (not specified in the Subject),
Reviewed-by: Alexander Sverdlin <alexander.sverdlin@xxxxxxxxxxx>

> ---
>  drivers/pmdomain/core.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pmdomain/core.c b/drivers/pmdomain/core.c
> index 842c4169e290..22791353249c 100644
> --- a/drivers/pmdomain/core.c
> +++ b/drivers/pmdomain/core.c
> @@ -2697,7 +2697,7 @@ int of_genpd_add_provider_simple(struct device_node *np,
>   genpd->sync_state = GENPD_SYNC_STATE_SIMPLE;
>   device_set_node(&genpd->dev, fwnode);
>   } else {
> - dev_set_drv_sync_state(dev, genpd_sync_state);
> + dev_add_sync_state(dev, genpd_sync_state);
>   }
>  
>   put_device(dev);
> @@ -2771,7 +2771,7 @@ int of_genpd_add_provider_onecell(struct device_node *np,
>   if (!dev)
>   sync_state = true;
>   else
> - dev_set_drv_sync_state(dev, genpd_sync_state);
> + dev_add_sync_state(dev, genpd_sync_state);
>  
>   put_device(dev);

--
Alexander Sverdlin
Siemens AG
www.siemens.com