Re: [PATCH v5 4/4] pps: clients: gpio: release pins to an inactive state on remove and shutdown

[Rodolfo Giometti]

On Tue, Sep 22, 2026 at 10:30:51AM +0000, Eliav Farber wrote:

The probe-failure path looks right to me now.  Only small things left.

> +static void pps_gpio_shutdown(struct platform_device *pdev)

This runs on every board, including the ones that describe no "inactive"
state, where the free_irq() and the echo teardown buy nothing.  Harmless
as far as I can see, but the commit message only speaks about the mux --
worth a line there?

>  	if (IS_ERR(data->pps)) {
>  		dev_err(dev, "failed to register IRQ %d as PPS source\n",
>  			data->irq);

This stayed dev_err() while both its neighbours became dev_err_probe().
Nothing is broken, but "matches the rest of the file" was the argument
for patch 1.

I would keep timer_delete_sync() here rather than moving to
timer_shutdown_sync(): the kernel-doc motivates the latter with the
circular-dependency case, which does not apply here -- the only rearm
path is the echo, behind free_irq().

Ciao,

Rodolfo