Re: [PATCH v7 13/43] btrfs: adapt readdir for encrypted and nokey names
From: Daniel Vacek
Date: Tue Sep 22 2026 - 10:46:30 EST
On Tue, 2 Jun 2026 at 01:44, Eric Biggers <ebiggers@xxxxxxxxxx> wrote:
> On Wed, May 13, 2026 at 10:52:47AM +0200, Daniel Vacek wrote:
> > + /*
> > + * TODO: This should maybe be using the crypto API, not the fallback,
> > + * but fscrypt uses the fallback and this is only used in emulation of
> > + * fscrypt's buffer sha256 method.
> > + */
>
> You can delete this TODO. The SHA-256 library functions just do the
> right thing now.
That's great! Thanks.
While at it, there was also a BUG for folios of order > 0. So I
cleaned up the whole function a bit.
--nX
> - Eric