Re: [REGRESSION 6.18.48 -> 6.18.49] hid-asus: ROG N-Key keyboard dead, also in 6.12.y

[Sasha Levin]

> So either revert d0754db7883c in both trees and rework the hid_is_usb()
> fix against the old structure, or backport 0919db9f3583 alongside it.
> The revert looks like less risk for stable, but that is your call.

Your diagnosis is correct, and thank you for the report descriptor, it made the
-EOVERFLOW unambiguous.

I went with the forward fix rather than the revert. Antheas named the right
commit in his reply: e82ae34af29e ("HID: asus: fortify keyboard handshake")
raises FEATURE_KBD_REPORT_SIZE to 64, so the GET_REPORT for 0x5a is large
enough for the 62 bytes your controller declares and asus_kbd_get_functions()
stops failing. It is queued for 6.18 and 6.12.  Reverting would have meant
reworking Jann's hid_is_usb() fix against the old structure on two trees, which
is the larger change of the two.

You offered to build a vanilla kernel and test. If you can confirm the keyboard
comes back on the GA403UV with that commit on top of 6.18.49, I would like to
have that before it goes out.

-- 
Thanks,
Sasha