Re: [PATCH] can: j1939: fix transport session leak and socket bind/connect validation
From: Simon Horman
Date: Tue Sep 22 2026 - 12:20:39 EST
On Sat, Sep 19, 2026 at 10:34:27PM +0000, Hui Peng wrote:
> Fix two issues in net/can/j1939/:
>
> 1. In j1939_tp_rxtimer() and session teardown
> (net/can/j1939/transport.c), ensure active transport sessions and
> skbs are properly cancelled and released on error or timeout.
> 2. In net/can/j1939/socket.c, validate socket state and address fields
> consistently across bind/connect/sendmsg.
FWIIW, these changes look reasonable to me.
But I think you should make a short patch-set, with a cover letter
and two patch-sei - one patch per fix.
And I think the description needs to describe in a little more detail
what each bug is, and how it is fixed. While it doesn't need
to mention the filename, which is already present in the diff.
Thanks!