Re: [PATCH v6 04/13] block: introduce dma map backed bio type

[Pavel Begunkov]

On 9/22/26 14:16, Christoph Hellwig wrote:
> On Mon, Sep 21, 2026 at 02:38:48PM +0100, Pavel Begunkov wrote:
> > Premapped buffers don't require a generic bio_vec since these have
> > already been dma mapped. Repurpose the bi_io_vec space to strore dmabuf
>
> s/strore/store/
>
> Can you please expland on the splitting considerations a bit?  Preferably
> both in a comment for the details, and in the commit log for how we
> arrived at them and why they are fine for now?

I'll add something to the commit log, but not sure which specific
details in comments you mean. Do you want me to expand the comment
above limiting the number of segments? Maybe I should add there that
it's stricter than necessary and might cause more splitting than
necessary? This one:

/*
 * Limit by the number of segments. We don't expose the underlying
 * mapping layout, but with a known minimum segment size, any I/O
 * consisting of N full segments should be able to cover at least
 * this much.
 */

--
Pavel Begunkov