Re: [PATCH 3/3] module: Remove obsolete __MODULE_STRING()

From: Aaron Tomlin

Date: Tue Sep 22 2026 - 13:45:36 EST


On Tue, Sep 22, 2026 at 03:32:23PM +0200, Petr Pavlu wrote:
> __MODULE_STRING() has been an alias for __stringify() since "[PATCH]
> MODULE_PARM support for older modules" [1] in 2002-12. That change also
> moved it to the graveyard section at the end of linux/module.h
>
> Remove __MODULE_STRING() now that all remaining uses have been replaced
> directly with __stringify().
>
> Link: https://git.kernel.org/tglx/history/c/136839a1b4 [1]
> Signed-off-by: Petr Pavlu <petr.pavlu@xxxxxxxx>
> ---
> include/linux/module.h | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/include/linux/module.h b/include/linux/module.h
> index 96cc98568eea..0d9157a2d487 100644
> --- a/include/linux/module.h
> +++ b/include/linux/module.h
> @@ -886,10 +886,6 @@ extern const struct kobj_type module_ktype;
>
> #define symbol_request(x) try_then_request_module(symbol_get(x), "symbol:" #x)
>
> -/* BELOW HERE ALL THESE ARE OBSOLETE AND WILL VANISH */
> -
> -#define __MODULE_STRING(x) __stringify(x)
> -
> #ifdef CONFIG_GENERIC_BUG
> void module_bug_finalize(const Elf_Ehdr *, const Elf_Shdr *,
> struct module *);
>
> --
> 2.55.0

Reviewed-by: Aaron Tomlin <atomlin@xxxxxxxxxxx>

--
Aaron Tomlin