Re: [PATCH v5 08/12] scsi: ufs: dwc: Sort CBCRCTRL and CBREFCLKCTRL2 by offset

[Frank Li]

On Tue, Sep 22, 2026 at 09:30:05AM +0200, Larisa Grigore wrote:
> The RMMI attribute defines in ufshcd-dwc.h are otherwise listed in
> ascending register-offset order, but CBREFCLKCTRL2 (0x8132) and
> CBCRCTRL (0x811F) were placed at the top out of order. Move them down
> into their sorted position next to the other CBCREG* attributes.
>
> Pure cleanup, no functional change.
>
> Signed-off-by: Larisa Grigore <larisa.grigore@xxxxxxxxxxx>
> ---

Nit: keep b4 review-by order, put it before your signed-off-by if need
respin patch.

Reviewed-by: Frank Li <Frank.Li@xxxxxxx>

>  drivers/ufs/host/ufshcd-dwc.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/ufs/host/ufshcd-dwc.h b/drivers/ufs/host/ufshcd-dwc.h
> index 53b523ef59df..1abf2b1deac4 100644
> --- a/drivers/ufs/host/ufshcd-dwc.h
> +++ b/drivers/ufs/host/ufshcd-dwc.h
> @@ -13,8 +13,6 @@
>  #include <ufs/ufshcd.h>
>
>  /* RMMI Attributes */
> -#define CBREFCLKCTRL2		0x8132
> -#define CBCRCTRL		0x811F
>  #define CBC10DIRECTCONF2	0x810E
>  #define CBRATESEL		0x8114
>  #define CBCREGADDRLSB		0x8116
> @@ -24,6 +22,8 @@
>  #define CBCREGRDLSB		0x811A
>  #define CBCREGRDMSB		0x811B
>  #define CBCREGRDWRSEL		0x811C
> +#define CBCRCTRL		0x811F
> +#define CBREFCLKCTRL2		0x8132
>
>  #define CBREFREFCLK_GATE_OVR_EN		BIT(7)
>
> --
> 2.43.0
>
>