Re: [PATCH 0/5] platform/x86: uniwill-laptop: Lightbar fixes

[Armin Wolf]

Am 05.09.26 um 15:01 schrieb Armin Wolf:

> This patch series mainly deals with various issues inside the code
> responsible for controlling the lightbar on supported devices.
>
> The first patch utilizes the improved multicolor LED API to report
> the correct brightness of the lightbar to userspace. The next two
> patches fix issues discovered inside the code for controlling
> animations, while the fourth patch fixes an issue with the naming
> of the LEDs in general. The last patch also adds support for another
> variant of the Intel NUC x15 laptop kit.
>
> All patches have been tested on said Intel NUC x15 laptop and appear
> to work.

Any thoughts on this series?

Thanks,
Armin Wolf

> Armin Wolf (5):
>    platform/x86: uniwill-laptop: Report correct lightbar brightness
>    platform/x86: uniwill-laptop: Implement rainbow animation as trigger
>    platform/x86: uniwill-laptop: Fix breathing animation on Intel QC
>    platform/x86: uniwill-laptop: Label multicolor LEDs correctly
>    platform/x86: uniwill-laptop: Extend support for the Intel NUC x15
>
>   .../ABI/removed/sysfs-driver-uniwill-laptop   |  10 +
>   .../ABI/testing/sysfs-driver-uniwill-laptop   |  15 +-
>   .../admin-guide/laptops/uniwill-laptop.rst    |   9 +-
>   MAINTAINERS                                   |   1 +
>   drivers/platform/x86/uniwill/Kconfig          |   1 +
>   drivers/platform/x86/uniwill/uniwill-acpi.c   | 225 +++++++++++-------
>   6 files changed, 161 insertions(+), 100 deletions(-)
>   create mode 100644 Documentation/ABI/removed/sysfs-driver-uniwill-laptop