Re: [PATCH v3 5/7] HID: hid-lenovo-go: normalize calibration failure status

From: Derek J. Clark

Date: Tue Sep 22 2026 - 17:26:18 EST


On September 22, 2026 11:54:36 AM PDT, Jiri Kosina <jikos@xxxxxxxxxx> wrote:
>On Sat, 5 Sep 2026, Aditya Dash wrote:
>
>> Hi Derek,
>>
>> The Stop reply changes based on calibration state. Its status appears to be
>> the current failure_mask + 1. However, this mask does not always match the
>> failure mask returned when calibration times out.
>>
>> Here are some requests and responses from the experiments done:
>
>[ ... snip ... ]
>
>Derek,
>
>do you have any final followup / verdict on this series, please?
>
>Thanks,
>
Hi Jiri,

Thanks for the ping. I missed the last response.

Aditya,

Seems pretty inconsistent and I can't really see a pattern emerging. I'll look into this more later when I revisit the driver architecture with some other much needed fixes. For now I think just reporting success/fail like we have been is fine, we just need to make sure we're reading from the correct byte.

Thanks,
Derek