Re: [PATCH v12 01/12] cxl: Move HDM decoder programming helpers

[Srirangan Madhavan]

On 9/11/26 4:30 PM, Jonathan Cameron wrote:
> > Introduce struct cxl_decoder_settings as a snapshot of HDM decoder
> > programming state. Collect endpoint skip and switch target-list state in
> > hdm.c while holding the DPA lock, then pass the snapshot to generic commit
> > helpers.
> >
> > Move the low-level settings-based register programming into resource.c so
> > later reset restore code can reuse it without depending on private decoder
> > types.
> This feels like two things in one patch. How much of this could be done by
> code movement in a precursor patch then real changes in a follow up?
>
> I'd like it to be a lot more obvious what has changed.
> Or failing that, introduce changes and then move the code in a follow
> up patch.  Would still be easier to review than this combined patch.
>
> Hopefully doing move and changes separately will also stop git diff
> randomly interleaving old and new functions that are unrelated.
>
> I've commented on some things but the diff is nasty enough I'll
> wait for a split version to take a closer look at the bulk of this.
>
> Jonathan

I split this up in v13:

  - patch 1 removes the stale 8-way interleave comment, noting that CXL 
2.0 introduced 16-way interleaving;
  - patch 3 is the mechanical movement of the HDM programming helpers;
  - patch 4 moves the decoder declarations without reordering their 
fields; and
  - patch 5 contains the settings-related semantic changes.

  I preserved the existing formatting and loop declarations in the 
movement patches, made the setup helper return void, and removed 
unrelated cleanup from the mechanical moves.

--
Regards,
Srirangan