Re: [PATCH] EDAC/i10nm: Fix mdev reference leak in i10nm_get_ddr_munits()
From: Borislav Petkov
Date: Tue Sep 22 2026 - 20:26:13 EST
On Tue, Sep 22, 2026 at 12:25:42PM -0700, Luck, Tony wrote:
> The above is a clear example that should not be tagged for stable. I'm
> suggesting that this EDAC bug doesn't meet the stable criteria.
Aaaha, I see it now. You basically want to point out that this patch
shouldnt've been tagged for stable in the first place.
And I agree - old, error handling path, patch is probably AI-caused, and
nothing really someone hits.
> I ought to have quizzed the submitter on why they thought it needed the
> tag.
Actually, that is your job. And you should remove it if you don't think the
patch is stable material. Because the stable tag causes a *lot* of work
downstream in distros and stable kernels picking up this patch and trying to
figure out why is it even stable material, what it is fixing, should their
customers upgrade, yadda yadda.
So, what I would do is, rebase the branch and zap the stable tag. The stable
tag is not something we should use willy-nilly but think twice whether we
really want to pile more work for distros and stable folks.
And if submitters cannot give a good reason why stable, then off it goes.
Thx.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette