Re: [PATCH net-next] octeontx2-af: Representor devlink id and port mapping

[Ratheesh Kannoth]

On 2026-09-22 at 10:46:15, netdev-bot+sashiko@xxxxxxxxxx (netdev-bot+sashiko@xxxxxxxxxx) wrote:
> Thank you for your contribution! Sashiko AI review found 8 potential
> issue(s) to consider.
>
> Critical: 0 · High: 2 (1) · Medium: 5 (1) · Low: 1
>
> If you believe none of the issues are legitimate, please reply to each
> issue of Medium severity or higher and explain why the AI is wrong.
> If any of them are legitimate and you plan to respin, please let patchwork
> know by including "pw-bot: cr" as a separate line at the end of your reply
> (one such reply per series is enough).
>
> - [High] The new cached fast path in rvu_mbox_handler_get_rep_cnt()
>   (af/rvu_rep.c:489-495) returns success before the relocated…
> - [High] The patch turns MBOX_MSG_GET_REP_CNT from 'last caller wins'
>   into 'first caller wins, permanently'.
> - [Medium] Commit message omits a functional rewrite of
>   rvu_mbox_handler_get_rep_cnt().
> - [Medium] Everything the patch adds is dead code with no in-tree
>   consumer, yet it permanently changes a shared AF<->PF mailbox wire…
> - [Medium] struct esw_cfg_req (MBOX_MSG_ESW_CFG, id 0x00e) is extended by
>   switch_id[MAX_PHYS_ITEM_ID_LEN] + switch_id_len (sizeof grows from 32…
> - [Medium] The new comment block above struct esw_cfg_req
>   (af/mbox.h:1787-1804), duplicated at af/rvu_rep.c:458 and…
> - [Medium] The patch introduces a lockless publish/subscribe protocol for
>   rvu->rep2pfvf_map / rvu->rep_cnt but omits the release/acquire pairing…
> - [Low] rvu_sw_port_id() (af/rvu_rep.c:208-226) duplicates, verbatim, the
>   linear rep2pfvf_map[] search implemented immediately above it in…

Will address in v2.

pw-bot: changes-requested