Re: [PATCH v10 04/17] iio: add IIO_FREQUENCY channel type

[Jonathan Cameron]

On Tue, 22 Sep 2026 17:07:45 +0100
Rodrigo Alencar <455.rodrigo.alencar@xxxxxxxxx> wrote:

> On 22/09/26 16:56, Rodrigo Alencar wrote:
> > esOn 29/07/26 09:25, Rodrigo Alencar via B4 Relay wrote:  
> > > From: Rodrigo Alencar <rodrigo.alencar@xxxxxxxxxx>
> > > 
> > > Add IIO_FREQUENCY channel type to support Direct Digital Synthesizer (DDS)
> > > devices that handles frequency values written directly to its buffered
> > > interface.  
> > 
> > ...
> >   
> > > Signed-off-by: Rodrigo Alencar <rodrigo.alencar@xxxxxxxxxx>
> > > ---
> > >  drivers/iio/industrialio-core.c | 1 +
> > >  include/uapi/linux/iio/types.h  | 1 +
> > >  tools/iio/iio_event_monitor.c   | 2 ++
> > >  3 files changed, 4 insertions(+)
> > > 
> > > diff --git a/drivers/iio/industrialio-core.c b/drivers/iio/industrialio-core.c
> > > index bdf3d4c06331..a45277bc5d99 100644
> > > --- a/drivers/iio/industrialio-core.c
> > > +++ b/drivers/iio/industrialio-core.c
> > > @@ -99,6 +99,7 @@ static const char * const iio_chan_type_name_spec[] = {
> > >  	[IIO_ATTENTION] = "attention",
> > >  	[IIO_ALTCURRENT] = "altcurrent",
> > >  	[IIO_COVERAGE] = "coverage",
> > > +	[IIO_FREQUENCY] = "frequency",  
> > 
> > Hi Jonathan,
> > 
> > Thanks for not giving up on this one! Taking a look at the testing branch,
> > I think this line was dropped during the rebase (addressing a conflict)  
Fixed up. Build test just running. Thanks!
> 
> btw, now that we are at this again, it crossed my mind...
> Is it fine to have a channel named the same way an attribute may be named?
> wonder if userspace tools could get confused.
I don't think so as they should be dealing with the ordering of different things
and we will always have a channel type before a modifier.

Jonathan

>