Re: [PATCH] smp: align struct __call_single_node to 8 bytes

[Philippe Mathieu-Daudé]

On 2026-09-06 4:39, Brian Cain wrote:
> Consumers walking call_single_queue cast each node to call_single_data_t
> and, given that type's declared over-alignment, the compiler may load
> llist.next and u_flags as one naturally aligned double word.  Embedders

"Embedders" is not easy to understand for non-native English speaker,
is it a typo? Regardless:

Reviewed-by: Philippe Mathieu-Daudé <philmd@xxxxxxxxxxxxxxxx>

> such as task_struct::wake_entry only guarantee pointer alignment, which
> faults on strict-alignment 32-bit architectures like hexagon.
>
> Cc: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
> Cc: Ingo Molnar <mingo@xxxxxxxxxx>
> Cc: "Paul E. McKenney" <paulmck@xxxxxxxxxx>
> Cc: Frederic Weisbecker <frederic@xxxxxxxxxx>
> Cc: linux-hexagon@xxxxxxxxxxxxxxx
> Signed-off-by: Brian Cain <brian.cain@xxxxxxxxxxxxxxxx>
> ---
>   include/linux/smp_types.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)