Re: [PATCH] can: m_can: pci: add missing pm_runtime_dont_use_autosuspend() call

From: Joshua Crofts

Date: Wed Sep 23 2026 - 03:31:59 EST


On Wed, 23 Sep 2026 09:06:59 +0200
"Markus Schneider-Pargmann" <msp@xxxxxxxxxxxx> wrote:

> On Fri Sep 18, 2026 at 1:15 PM CEST, Joshua Crofts wrote:
> > On Fri, 18 Sep 2026 11:24:09 +0200
> > "Markus Schneider-Pargmann" <msp@xxxxxxxxxxxx> wrote:
> >
> >> Hi Joshua,
> >>
> >> On Wed Sep 16, 2026 at 2:42 PM CEST, Joshua Crofts wrote:
> >> > m_can_pci_remove() forgets to call pm_runtime_dont_use_autosuspend() on
> >> > teardown, even though autosuspend is enabled in m_can_pci_probe().
> >> >
> >> > Add the missing function call.
> >> >
> >>
> >> Can you please add a Fixes: tag?
> >
> > I guess it's not a problem, however we had a discussion in the
> > USB subsystem whether this type of patch is a fix and ended up
> > agreeing that it's more hardening, hence no Fixes tag.
> >
> > Alright if I just append the tag here for b4 to collect?
>
> Yes, that's ok for me.
>

Fixes: cab7ffc0324f ("can: m_can: add PCI glue driver for Intel Elkhart Lake")

--
Kind regards,
Joshua Crofts