Re: [PATCH net] net: ethtool: let tsconfig reach a PHY-only timestamp provider

[Kory Maincent]

On 9/22/26 09:08, Nicolai Buchwitz wrote:
> TSCONFIG_GET and TSCONFIG_SET reject a device that implements neither
> hwtstamp NDO, even when its PHY can serve the request. The ioctls they
> meant to replace handle it, so the two interfaces disagree on the same
> hardware and user space has to pick one.
>
> Drop both checks and let the phylib helpers decide, like the ioctls do.
>
> As this makes a netdev provider reachable without ndo_hwtstamp_get, test
> for the callback before calling it.
>
> Fixes: 6e9e2eed4f39 ("net: ethtool: Add support for tsconfig command to get/set hwtstamp config")
> Signed-off-by: Nicolai Buchwitz <nb@xxxxxxxxxxx>

Reviewed-by: Kory Maincent <kory.maincent@xxxxxxxxxxx>

Thank you!
--
Köry Maincent, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com