Re: [PATCH] crypto: starfive: propagate clock and reset errors

From: Herbert Xu

Date: Wed Sep 23 2026 - 04:53:42 EST


On Sun, Aug 30, 2026 at 09:48:35PM +0800, Pengpeng Hou wrote:
> starfive_cryp_probe() publishes the crypto device after enabling its clocks
> and deasserting its reset without checking whether those operations
> succeeded.
>
> Check each hardware activation step and unwind only the resources that were
> actually enabled before returning the error.
>
> Fixes: 42ef0e944b01 ("crypto: starfive - Add crypto engine support")
> Signed-off-by: Pengpeng Hou <pengpeng@xxxxxxxxxxx>
> ---
> drivers/crypto/starfive/jh7110-cryp.c | 20 +++++++++++++++-----
> 1 file changed, 15 insertions(+), 5 deletions(-)

Patch applied. Thanks.
--
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt