Re: [PATCH v3] platform/wmi: Move ASUS platform drivers from x86 to wmi/asus

[Hans de Goede]

Hi,

On 23-Sep-26 10:29, chipang_kao wrote:
> Hi Armin, Hans, and all,
> 
> Thank you for the feedback, Armin!
> 
> I completely agree that separating WMI core infrastructure from WMI client
> drivers makes logical sense. The reason v3 relocated the drivers to
> drivers/platform/wmi/asus/ was based on Hans's earlier suggestion to use the
> WMI subsystem hierarchy. However, Armin's point about keeping client drivers in
> a brand-specific directory like drivers/platform/asus/ also provides a very
> clean, cross-architecture solution for all ASUS platform drivers.
> 
> Regarding the background: yes, the RTX Spark is indeed our target platform.
> ASUS plans to provide user-space applications on Ubuntu to control platform
> features via the WMI interface. During our bring-up on ARM64, we found that no
> ASUS WMI modules were currently available for this architecture due to the
> existing x86 Kconfig restriction. This patch series aims to enable
> cross-architecture WMI support to address this gap.
> 
> I am happy to go with either path (wmi/asus/ vs. platform/asus/). Hans, Armin,
> what would be the preferred target directory before I prepare [PATCH v4]?

If I understand things correctly then Armin prefers drivers/platform/asus
that is completely fine with me, so lets go with drivers/platform/asus .

Having that will also be useful to share any platform specific drivers
which directly use ACPI calls rather then WMI.

E.g. I can see a drivers/platform/lenovo show up to use thinkpad_acpi
on ThinkPad ARM64 laptops.

Regards,

Hans