Re: [PATCH] lib/842: depend on the decompressor for KUnit tests

From: Herbert Xu

Date: Wed Sep 23 2026 - 05:14:03 EST


On Thu, Sep 17, 2026 at 07:56:45AM +0200, Karl Mehltretter wrote:
> 842_DECOMPRESS_KUNIT_TEST selects the decompressor even when no other
> option needs it, including through KUNIT_ALL_TESTS.
>
> Depend on 842_DECOMPRESS as required by
> Documentation/dev-tools/kunit/style.rst. This also prevents the test from
> promoting a modular decompressor to built-in.
>
> Fixes: cca072cb1423 ("lib/842: add KUnit tests for the decompressor")
> Reported-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> Closes: https://lore.kernel.org/r/CAMuHMdVcZ5cV4-HrjLYfFKh6UshiVxq5eXCNyp0Z1k_SMAvF5g@xxxxxxxxxxxxxx/
> Assisted-by: LLM
> Signed-off-by: Karl Mehltretter <kmehltretter@xxxxxxxxx>
> ---
> Follow-up to the accepted commit, based on cryptodev-2.6/master.
>
> Testing: Checked Kconfig dependency resolution for eight x86_64
> configurations before and after the change, including KUNIT_ALL_TESTS
> and modular/built-in combinations.
>
> lib/Kconfig.debug | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Patch applied. Thanks.
--
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt