Re: [PATCH v3 2/6] wifi: rtw88: 8723b: add the RTL8723B BB, RF and AGC tables

[Luka Gejak]

September 23, 2026 at 11:59, "Ping-Ke Shih" <pkshih@xxxxxxxxxxx> wrote:

> 
> Luka Gejak <luka.gejak@xxxxxxxxx> wrote:
> 
> > 
> > Luka Gejak <luka.gejak@xxxxxxxxx> wrote:
> > 
> >  >
> >  > Luka Gejak <luka.gejak@xxxxxxxxx> wrote:
> >  > > +// SPDX-License-Identifier: GPL-2.0 OR BSD-3-Clause
> >  > > +/*
> >  > > + * Copyright(c) 2007-2017 Realtek Corporation
> >  > > + * Copyright(c) Michael Straube <straube.linux@xxxxxxxxx>
> >  > > + * Copyright(c) 2024-2026 Luka Gejak <luka.gejak@xxxxxxxxx>
> >  > >
> >  > I'm not sure if we should claim copyright year back to 2007?
> >  >
> >  > What would you prefer, just tell me and I will change it?
> >  >
> >  You can reference what Bitterblue did [1]. I don't have much study
> >  about the copyright.
> > 
> >  [1] 1a7545784642 ("wifi: rtw88: Add rtw8814a.{c,h}")
> > 
> >  
> >  He uses 2025, so should I copy his line for Realtek copyright header?
> > 
> Maybe "Copyright(c) 2026 Realtek Corporation"
> 
> If needed, more copyright are also okay, but I don't know much about that.
> You can study Documentation or somewhere to know more.
> 

Understood, will do.

> > 
> > Also I will address all comments and send v4 tonight/tomorrow morning.
> > 
> No rush. Deeply what review the patches before sending is more important.
> As this patchset is large LOC, one iteration spends me a lot of time. I'd
> minimize iteration as few as possible.
> 
> Ping-Ke
>

I agree that less iterations are better, and architecturally I
believe very little, if any changes should be made, therefore I
think only style changes are left, and I will try to catch as
many myself when I review today.

Best regards,
Luka Gejak