Re: [PATCH v6 1/3] dt-bindings: i3c: Add support for Qualcomm I3C controller
From: Mukesh Savaliya
Date: Wed Sep 23 2026 - 05:36:00 EST
On 9/22/2026 3:40 PM, Konrad Dybcio wrote:
On 9/21/26 10:28 PM, Mukesh Savaliya wrote:
Hi Konrad, Apologies for the delayed response. I was waiting to verify the changes and ensure all the suggested updates were properly incorporated. The effort was further delayed due to some slave-side setup issues.
I have now addressed and validated all the suggested changes except one, which I have responded to separately below.
On 7/18/2025 2:21 AM, Konrad Dybcio wrote:
On 7/1/25 9:18 AM, Mukesh Kumar Savaliya wrote:Do you mean as below ?
Add device tree bindings for the Qualcomm I3C controller. This includes
the necessary documentation and properties required to describe the
hardware in the device tree.
Signed-off-by: Mukesh Kumar Savaliya <mukesh.savaliya@xxxxxxxxxxxxxxxx>
Reviewed-by: Rob Herring (Arm) <robh@xxxxxxxxxx>
---
[...]
+properties:
+ compatible:
+ const: qcom,geni-i3c
+
+ reg:
+ maxItems: 1
In another patchset, you expanded 'reg', can you coalesce that change
into here, so that we don't have to worry about backwards compat?
reg:
minItems: 1
maxItems: 2
No, I meant that since you know in advance you'll need the bindings
to be altered, simply squash the two bindings patches together and
submit as one
Konrad
Sure, will publish full dt-binding describing I3C hardware including IBI related information and accordingly update the commit log.
I did it earlier to add support of IBI feature, but i plan to do it later. Right now, i only want to add plain i3c controller support without IBI hence.
I shall add expanded reg while adding i3c support. For now, its not required. Please let me know if this is fine for now.
Konrad