Re: [PATCH v10 02/10] media: mediatek: decoder: Add a new platform data member

[AngeloGioacchino Del Regno]

On 9/23/26 10:12, Kyrie Wu wrote:
> Move the chip model information into the codec match data
> and remove the second compatible matching code.
>
> Signed-off-by: Kyrie Wu <kyrie.wu@xxxxxxxxxxxx>
> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx>
> Reviewed-by: Nicolas Dufresne <nicolas.dufresne@xxxxxxxxxxxxx>
> ---
>   .../mediatek/vcodec/decoder/mtk_vcodec_dec.c  |   2 +-
>   .../mediatek/vcodec/decoder/mtk_vcodec_dec.h  |   5 +
>   .../vcodec/decoder/mtk_vcodec_dec_drv.c       |  40 ++-----
>   .../vcodec/decoder/mtk_vcodec_dec_drv.h       |  17 +--
>   .../vcodec/decoder/mtk_vcodec_dec_hw.c        |   2 +-
>   .../vcodec/decoder/mtk_vcodec_dec_stateful.c  |   1 +
>   .../vcodec/decoder/mtk_vcodec_dec_stateless.c | 104 +++++++++++++-----
>   7 files changed, 96 insertions(+), 75 deletions(-)

..snip..

> diff --git a/drivers/media/platform/mediatek/vcodec/decoder/mtk_vcodec_dec_drv.h b/drivers/media/platform/mediatek/vcodec/decoder/mtk_vcodec_dec_drv.h
> index 53d1708b012b..153c617df78d 100644
> --- a/drivers/media/platform/mediatek/vcodec/decoder/mtk_vcodec_dec_drv.h
> +++ b/drivers/media/platform/mediatek/vcodec/decoder/mtk_vcodec_dec_drv.h
> @@ -21,17 +21,6 @@
>   #define IS_VDEC_INNER_RACING(capability) ((capability) & MTK_VCODEC_INNER_RACING)
>   #define IS_VDEC_SUPPORT_EXT(capability) ((capability) & MTK_VDEC_IS_SUPPORT_EXT)
>   
> -enum mtk_vcodec_dec_chip_name {
> -	MTK_VDEC_INVAL = 0,
> -	MTK_VDEC_MT8173 = 8173,
> -	MTK_VDEC_MT8183 = 8183,
> -	MTK_VDEC_MT8186 = 8186,
> -	MTK_VDEC_MT8188 = 8188,
> -	MTK_VDEC_MT8192 = 8192,
> -	MTK_VDEC_MT8195 = 8195,
> -	MTK_VDEC_MT8196 = 8196,
> -};
> -
>   /*
>    * enum mtk_vdec_format_types - Structure used to get supported
>    *		  format types according to decoder capability
> @@ -108,6 +97,7 @@ struct vdec_pic_info {
>    *
>    * @is_subdev_supported: whether support parent-node architecture(subdev)
>    * @uses_stateless_api: whether the decoder uses the stateless API with requests
> + * @chip_model: platforms configuration values
>    */
>   struct mtk_vcodec_dec_pdata {
>   	void (*init_vdec_params)(struct mtk_vcodec_dec_ctx *ctx);
> @@ -129,6 +119,7 @@ struct mtk_vcodec_dec_pdata {
>   
>   	bool is_subdev_supported;
>   	bool uses_stateless_api;
> +	unsigned int chip_model;

I already gave my R-b but I just noticed:

Please use u16 here, 16 bits are way more than enough for this.

>   };
>   
>   /**
> @@ -277,7 +268,7 @@ struct mtk_vcodec_dec_ctx {
>    * @dec_racing_info_mutex: mutex lock used for inner racing mode
>    * @dbgfs: debug log related information
>    *
> - * @chip_name: used to distinguish platforms and select the correct codec configuration values
> + * @chip_model: used to distinguish platforms and select the correct codec configuration values
>    */
>   struct mtk_vcodec_dec_dev {
>   	struct v4l2_device v4l2_dev;
> @@ -321,7 +312,7 @@ struct mtk_vcodec_dec_dev {
>   	struct mutex dec_racing_info_mutex;
>   	struct mtk_vcodec_dbgfs dbgfs;
>   
> -	enum mtk_vcodec_dec_chip_name chip_name;
> +	unsigned int chip_model;

same here


Cheers,
Angelo