Re: misc: fastrpc: is a ctx_idr IDR -> XArray conversion wanted?
From: Greg KH
Date: Wed Sep 23 2026 - 06:55:59 EST
On Wed, Sep 23, 2026 at 03:10:01PM +0530, Murali Krishna wrote:
> On Wed, Sep 23, 2026 at 11:28:52AM +0200, Greg KH wrote:
> > I doubt it's really needed unless you can prove some sort of advantage
> > for the change? Is it faster on a measurable path, or less memory or
> > something else that would justify the churn?
> >
> > idr is still a fine structure/api for many things, they don't all have
> > to go away, otherwise we would have done so long ago.
>
> Understood, and I cannot show such an advantage. struct idr is already
> built on the same underlying tree as the xarray, so there is nothing
> measurable to gain here in speed or memory -- it would be churn for its
> own sake. I will drop the conversion.
>
> Thank you for answering so quickly, and for explaining the reasoning
> rather than just saying no. That was useful to me.
>
> If there is something in fastrpc, or elsewhere in drivers/misc, that you
> would actually like to see worked on, I would be glad to take on
> something small and learn from the review.
Please help with review and testing of all of the patches that keep
getting sent for this driver, that would be the best help at this point
in time and will show you what needs to be done on it in the future.
thanks,
greg k-h