Re: [PATCH] printk_ringbuffer: Avoid needless read of prb_desc
From: Petr Mladek
Date: Wed Sep 23 2026 - 07:37:26 EST
On Tue 2026-09-22 14:25:20, Wang Wensheng wrote:
> Since commit f244b4dc53e5 ("printk: ringbuffer: Improve prb_next_seq()
> performance"), desc_read() allows @desc_out to be NULL. We can drop the
> local `desc` variable in desc_reopen_last() and prb_first_seq(). Also
> update the comment for desc_read().
>
> Signed-off-by: Wang Wensheng <wsw9603@xxxxxxx>
Great catch! Looks good to me:
Reviewed-by: Petr Mladek <pmladek@xxxxxxxx>
I am going to wait few more days for more potential feedback.
I'll commit it the following week if nobody complains.
Best Regards,
Petr