Re: [PATCH RFC 02/15] dt-bindings: phy: qcom,x1e80100-csi2-phy: Add Hawi and Maili compatibles

[Bryan O'Donoghue]

On 23/09/2026 12:02, Nihal Kumar Gupta wrote:
> Hawi and Maili integrate the same CSIPHY IP as Kaanapali with an
> identical register interface. Add qcom,hawi-csi2-phy and
> qcom,maili-csi2-phy falling back to qcom,kaanapali-csi2-phy.
>
> Signed-off-by: Nihal Kumar Gupta <nihal.gupta@xxxxxxxxxxxxxxxx>
> ---
>   .../devicetree/bindings/phy/qcom,x1e80100-csi2-phy.yaml      | 12 +++++++++---
>   1 file changed, 9 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/phy/qcom,x1e80100-csi2-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,x1e80100-csi2-phy.yaml
> index 24ca06b97656077cf168e72b2a32f493d9c06af2..84d70e3e5783980bc76807869f00e7d112a046ae 100644
> --- a/Documentation/devicetree/bindings/phy/qcom,x1e80100-csi2-phy.yaml
> +++ b/Documentation/devicetree/bindings/phy/qcom,x1e80100-csi2-phy.yaml
> @@ -16,9 +16,15 @@ description:
>
>   properties:
>     compatible:
> -    enum:
> -      - qcom,kaanapali-csi2-phy
> -      - qcom,x1e80100-csi2-phy
> +    oneOf:
> +      - enum:
> +          - qcom,kaanapali-csi2-phy
> +          - qcom,x1e80100-csi2-phy
> +      - items:
> +          - enum:
> +              - qcom,hawi-csi2-phy
> +              - qcom,maili-csi2-phy
> +          - const: qcom,kaanapali-csi2-phy
>
>     reg:
>       maxItems: 1
>
> --
> 2.34.1

I don't think you should depend on kaanapali unless you have a good 
reason to.

---
bod