Re: [PATCH v2 3/5] media: rockchip: rkcif: add a callback for the MIPI ID_CTRL1 register

[Mehdi Djait]

Hello Amin,

Thank you for the patch!

On Mon, Sep 21, 2026 at 05:29:59PM +0200, Amin Gattout wrote:
> The contents of the MIPI ID_CTRL1 register differ between variants. The
> RK3568 and RK3588 hold the capture size there, while the RK3576 uses it
> for the virtual channel and data type filter.
> 
> Let each variant provide a callback that builds the register value, in
> preparation for the RK3576 support. Variants that do not provide one
> keep writing the capture size, so their behavior is unchanged.
> 

Reviewed-by: Mehdi Djait <mehdi.djait@xxxxxxxxxxxxxxx>

> Signed-off-by: Amin Gattout <amin.gattout@xxxxxxxxx>

--
Kind Regards
Mehdi Djait