Re: [PATCH net-next v3] net: pcs: enable autonegotiation for 10g-usxgmii

[Vladimir Oltean]

On Tue, Sep 22, 2026 at 05:54:46PM +0200, Patryk Biel wrote:
> The Lynx PCS USXGMII setup programs the replicator advertisement, but
> does not explicitly enable and restart in-band autonegotiation or program
> the replicator link timers.
> 
> This leaves the PCS dependent on firmware or bootloader state. Systems
> which do not get the USXGMII replicator preconfigured before Linux may
> therefore fail to negotiate the link correctly.
> 
> After programming the USXGMII device ability, configure the replicator
> BMCR with reset, autonegotiation enable and autonegotiation restart. Also
> program the replicator link timer registers using the value returned by
> phylink_get_link_timer_ns()
> 
> Co-developed-by: Vladimir Oltean <vladimir.oltean@xxxxxxx>
> Signed-off-by: Vladimir Oltean <vladimir.oltean@xxxxxxx>
> Signed-off-by: Patryk Biel <pbiel7@xxxxxxxxx>
> ---

There are 2 problems with the commit message. First the prefix should be
"net: pcs: lynx:", and second, you say you enable autoneg for 10g-usxgmii
(which doesn't exist) instead of saying you enable it for 10g-qxgmii and
usxgmii (to correctly reflect the code). You should probably fix both.

Anyway, with both addressed:
Reviewed-by: Vladimir Oltean <vladimir.oltean@xxxxxxx>
Tested-by: Vladimir Oltean <vladimir.oltean@xxxxxxx>