Re: [PATCH v5 09/15] iommu/arm-smmu-v3: Disable PRI when no IRQ handler is registered
From: Jason Gunthorpe
Date: Wed Sep 23 2026 - 14:42:00 EST
On Tue, 15 Sep 2026 09:38:21 -0700, Nicolin Chen <nicolinc@xxxxxxxxxx> wrote:
> arm_smmu_setup_irqs() can leave the PRIQ without any registered handler if
> its IRQ is missing, its request fails, or the combined IRQ request fails.
> These paths warn but leave ARM_SMMU_FEAT_PRI set.
>
> This function itself would then go on to enable IRQ_CTRL_PRIQ_IRQEN, even
> though no handler will drain the queue. A later patch also enables PRI on
> such endpoints. The caller already enabled CR0_PRIQEN before this function
> even runs.
>
> [...]
Reviewed-by: Jason Gunthorpe <jgg@xxxxxxxxxx>
--
Jason