Re: [PATCH] sched_ext: Update scx_dispatch_dequeue() comments

[Tejun Heo]

Hello, Usama.

On Wed, Sep 23, 2026 at 02:34:18PM -0700, Usama Arif wrote:
>  		/*
> -		 * When dispatching directly from the BPF scheduler to a local
> -		 * DSQ, the task isn't associated with any DSQ but
> -		 * @p->scx.holding_cpu may be set under the protection of
> -		 * %SCX_OPSS_DISPATCHING.
> +		 * When moving a task to a local DSQ through either direct dispatch
> +		 * or remote consumption, the task isn't associated with any DSQ but
> +		 * @p->scx.holding_cpu may be set.
>  		 */

dispatch_to_local_dsq() sets holding_cpu for ops.dispatch() inserts too,
not just direct dispatches. Can you name dispatch_to_local_dsq() instead,
here and in the description?

Clearing holding_cpu here is also how dispatch_to_local_dsq() learns that
it lost to a dequeue. The old comment on the other branch described that,
but for the wrong branch. Can you add a sentence about it here?

Can you also rewrap both comments at 80 columns? A few lines go past it.

Thanks.

--
tejun