Re: [PATCH] ipv6: exthdrs: copy old IPv6 header before skb_mac_header_rebuild() in ipv6_rpl_srh_rcv()

[Simon Horman]

On Wed, Sep 23, 2026 at 03:06:36PM +0000, netdev-bot+sashiko@xxxxxxxxxx wrote:
> Thank you for your contribution! Sashiko AI review found 2 potential
> issue(s) to consider.
> 
> Critical: 0 · High: 1 (1) · Medium: 1 · Low: 0
> 
> If you believe none of the issues are legitimate, please reply to each
> issue of Medium severity or higher and explain why the AI is wrong.
> If any of them are legitimate and you plan to respin, please let patchwork
> know by including "pw-bot: cr" as a separate line at the end of your reply
> (one such reply per series is enough).

The above requires a response.
But as there is none, I will try to move things along.

> - [High] Incomplete/inverted fix in ipv6_rpl_srh_rcv()
>   (net/ipv6/exthdrs.c): moving `memmove(skb->data, oldhdr, sizeof(struct…

This [High] issues to seem to need to be addressed and the suggestion that
accompanies the issue seems sensible to me.

> - [Medium] Commit message inaccuracies plus an undisclosed functional
>   change.

And as given the presence of the [High] issue this one may as well be fixed
too.

> 
> Pre-existing issues:
> - [High] ipv6_rpl_srh_rcv() (net/ipv6/exthdrs.c) mutates the skb data
>   area without ever guaranteeing exclusive ownership of it, unlike every…

This seems to be a real problem but orthogonal to this patch.
I would suggest that it likely exists elsewhere too.

-- 
pw-bot: changes-requested