Re: [PATCH net-next v3 2/4] dt-bindings: net: adi,ad3306: add reset-gpios property

From: Krzysztof Kozlowski

Date: Thu Sep 24 2026 - 07:52:04 EST


On Sat, Sep 19, 2026 at 12:49:32AM +0200, Alessandro Zini wrote:
> The ADIN1140/AD3306 MAC-PHY has an active-low hardware reset pin, and the
> driver binds to the common OA TC6 library which is gaining support for an
> optional reset GPIO. As the schema uses "unevaluatedProperties: false", a
> board description using the property would otherwise be rejected.

Whatever library takes or does, will not generate any warnings. I do not
see at all how unevaluatedFalse is relevant here. There is no way
changing library C code causes any warnings. At least as of now.

Also, no properties should be added because some library gets its
support. You add the property because hardware has it.

If the first sentence is correct, then it is enough and keep only this.

> Add the optional reset-gpios property to describe the connection to that
> pin.

This is also redundant, directly implied by the first one.

With drpoping of both:

Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxxxxx>

Best regards,
Krzysztof