Re: [PATCH v1 1/2] dt-bindings: mmc: snps,dwcmshc-sdhci: Add starfive,jhb100-dwcmshc

[Krzysztof Kozlowski]

On Sat, Sep 19, 2026 at 02:29:49AM -0700, Changhuang Liang wrote:
> Add compatible string "starfive,jhb100-dwcmshc" for the StarFive
> JHB100 SoC.
> 
> The JHB100 controller uses three clocks (core, bus and cclk_tx) and a
> single reset, so relax the common resets/reset-names minItems from 4
> to 1 and add a dedicated conditional schema for the JHB100 compatible
> that constrains the clocks, clock-names, resets, reset-names and the
> required starfive,jhb100-per1-syscon property. The property describes
> the phandle to the PER1 SYSCON and the offset of the register holding
> the upper DMA address bits [35:32] of the eMMC DMA address, used to
> extend the default 32-bit DMA capability to 36-bit.
> 
> Also rework the existing if/else blocks so that the JHB100 compatible
> is excluded from the branch that requires the extra resets, while
> keeping the same constraints for the other SoCs.
> 
> Signed-off-by: Changhuang Liang <changhuang.liang@xxxxxxxxxxxxxxxx>
> ---
>  .../bindings/mmc/snps,dwcmshc-sdhci.yaml      | 74 ++++++++++++++++++-
>  1 file changed, 70 insertions(+), 4 deletions(-)
> 

We are probably on the verge of readability of this binding, with
multiple if:then:else and quite some combinations.

Code looks correct, though I think we should for the next variant split
it per each device with some common binding.

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxxxxx>

Best regards,
Krzysztof